Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for shortcuts.dart API examples. #147433

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev/bots/check_code_samples.dart
Expand Up @@ -432,8 +432,6 @@ final Set<String> _knownMissingTests = <String>{
'examples/api/test/widgets/image/image.frame_builder.0_test.dart',
'examples/api/test/widgets/image/image.loading_builder.0_test.dart',
'examples/api/test/widgets/shortcuts/logical_key_set.0_test.dart',
'examples/api/test/widgets/shortcuts/shortcuts.0_test.dart',
'examples/api/test/widgets/shortcuts/shortcuts.1_test.dart',
'examples/api/test/widgets/shortcuts/callback_shortcuts.0_test.dart',
'examples/api/test/widgets/page_storage/page_storage.0_test.dart',
'examples/api/test/widgets/scrollbar/raw_scrollbar.1_test.dart',
Expand Down
55 changes: 55 additions & 0 deletions examples/api/test/widgets/shortcuts/shortcuts.0_test.dart
@@ -0,0 +1,55 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/services.dart';
import 'package:flutter_api_samples/widgets/shortcuts/shortcuts.0.dart'
as example;
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('displays correct labels', (WidgetTester tester) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
testWidgets('displays correct labels', (WidgetTester tester) async {
testWidgets('Verify correct labels are displayed', (WidgetTester tester) async {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar title in other test

await tester.pumpWidget(
const example.ShortcutsExampleApp(),
);

expect(find.text('Shortcuts Sample'), findsOneWidget);
expect(
find.text('Add to the counter by pressing the up arrow key'),
findsOneWidget,
);
expect(
find.text('Subtract from the counter by pressing the down arrow key'),
findsOneWidget,
);
expect(find.text('count: 0'), findsOneWidget);
});

testWidgets('updates counter on arrowUp and arrowDown press', (WidgetTester tester) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
testWidgets('updates counter on arrowUp and arrowDown press', (WidgetTester tester) async {
testWidgets(' Up and down arrow press updates counter', (WidgetTester tester) async {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar title in other test

await tester.pumpWidget(
const example.ShortcutsExampleApp(),
);

int counter = 0;

while (counter < 10) {
expect(find.text('count: $counter'), findsOneWidget);

// Increment the counter.
await tester.sendKeyEvent(LogicalKeyboardKey.arrowUp);
await tester.pump();

counter++;
}

while (counter >= 0) {
expect(find.text('count: $counter'), findsOneWidget);

// Decrement the counter.
await tester.sendKeyEvent(LogicalKeyboardKey.arrowDown);
await tester.pump();

counter--;
}
});
}
55 changes: 55 additions & 0 deletions examples/api/test/widgets/shortcuts/shortcuts.1_test.dart
@@ -0,0 +1,55 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/services.dart';
import 'package:flutter_api_samples/widgets/shortcuts/shortcuts.1.dart'
as example;
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('displays correct labels', (WidgetTester tester) async {
await tester.pumpWidget(
const example.ShortcutsExampleApp(),
);

expect(find.text('Shortcuts Sample'), findsOneWidget);
expect(
find.text('Add to the counter by pressing the up arrow key'),
findsOneWidget,
);
expect(
find.text('Subtract from the counter by pressing the down arrow key'),
findsOneWidget,
);
expect(find.text('count: 0'), findsOneWidget);
});

testWidgets('updates counter on arrowUp and arrowDown press', (WidgetTester tester) async {
await tester.pumpWidget(
const example.ShortcutsExampleApp(),
);

int counter = 0;

while (counter <= 10) {
expect(find.text('count: $counter'), findsOneWidget);

// Increment the counter.
await tester.sendKeyEvent(LogicalKeyboardKey.arrowUp);
await tester.pump();

counter += 2;
}

while (counter >= 0) {
expect(find.text('count: $counter'), findsOneWidget);

// Decrement the counter.
await tester.sendKeyEvent(LogicalKeyboardKey.arrowDown);
await tester.pump();

counter -= 2;
}
});
}