New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting rid of containers #147432
Merged
nate-thegrate
merged 44 commits into
flutter:master
from
nate-thegrate:no-more-containers
May 9, 2024
+480
−428
Merged
Getting rid of containers #147432
Changes from 31 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
2df9506
get rid of containers!
nate-thegrate 88ef5c7
fix analysis problems
nate-thegrate 5b3fe23
Merge github.com:flutter/flutter into no-more-containers
nate-thegrate 2eb9b4d
Merge github.com:flutter/flutter into no-more-containers
nate-thegrate f5868fb
more container refactoring!
nate-thegrate 49c3c2d
Merge branch 'master' into no-more-containers
nate-thegrate 5130eb8
revert `DecoratedBox` changes
nate-thegrate 8c2e67e
update CupertinoListTile & relevant test
nate-thegrate 8a0baa9
fix CupertinoContextMenu test
nate-thegrate 532a819
revert data_table.dart for now
nate-thegrate 9fd914f
update card_theme_test.dart
nate-thegrate 50fcc9b
fix stepper_test.dart
nate-thegrate 4087e62
improve drawer.dart and relevant test
nate-thegrate 1943456
fix card_test.dart
nate-thegrate a97d690
update dropdown_menu.dart and relevant test
nate-thegrate feeeaa9
fix popup_menu_test
nate-thegrate 90614d8
remove redundant import
nate-thegrate 571da17
more semantics!
nate-thegrate b52f2ca
pushed to the wrong branch 😑
nate-thegrate 7bed677
fix context_menu_test.dart
nate-thegrate 79a76d5
list_section tweak
nate-thegrate 2986d4d
reverting `CupertinoListTile` & `CupertinoListSection` for now
nate-thegrate 8130456
Merge branch 'master' into no-more-containers
nate-thegrate 99c2c1b
fix drawer_theme_test.dart
nate-thegrate 5c8c311
fix navigation_drawer.dart and the relevant test
nate-thegrate 101c33f
fix progress_indicator_test.dart
nate-thegrate d3bf5be
update autocomplete.dart & relevant test
nate-thegrate 202fdfb
revert autocomplete changes for now
nate-thegrate defbf62
update popup_menu.dart & relevant test
nate-thegrate eba16f4
update "Material2 - PopupMenuItem default padding"
nate-thegrate 4875fef
revert cupertino changes (since the PR is pretty huge)
nate-thegrate 20197d8
factor out `LimitedBox` objects
nate-thegrate 67eb7f5
re-implement `LimitedBox` for drawer, tabs, expansion_panel
nate-thegrate 7314e0a
clean up constraints
nate-thegrate 6c2ce6b
update tests
nate-thegrate 5f55cf3
Merge branch 'master' into no-more-containers
nate-thegrate e7217f6
Merge github.com:flutter/flutter into no-more-containers
nate-thegrate a152a4c
re-implement `cupertino/` stuff
nate-thegrate 73bdeba
Merge github.com:flutter/flutter into no-more-containers
nate-thegrate 722f7dd
Merge github.com:flutter/flutter into no-more-containers
nate-thegrate 0dfb13d
keep cupertino & material `a-d`, revert others
nate-thegrate 5a76fd4
improve date_picker.dart
nate-thegrate 503d9f6
Merge github.com:flutter/flutter into no-more-containers
nate-thegrate 5ac446b
Merge branch 'master' into no-more-containers
nate-thegrate File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use
SizedBox.shrink()
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the boxes are unconstrained, then yes! I'll switch it over and see if anything breaks :)