Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Material build method #147430

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nate-thegrate
Copy link
Member

@nate-thegrate nate-thegrate commented Apr 26, 2024

I made a lot of random tweaks while working on issue #147392, so I thought it'd be good to file these changes as a separate pull request so that eventually the main PR will be easier to review.

Currently, the Material build method makes multiple calls to Theme.of(context), and _MaterialInterior has a nullable shadowColor (even though the values passed to it are always non-nullable).


Commit 3ffb2e0 reverts a change to the elevation calculation, so golden test files should no longer be affected.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 26, 2024
@nate-thegrate nate-thegrate marked this pull request as ready for review April 27, 2024 01:56
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #147430 at sha d6dde8a

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 27, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Apr 30, 2024

test-exempt: code refactor with no semantic change
(i did not review the code to verify that there are no semantic changes, only that that was the intent)

@Piinks Piinks requested a review from justinmc May 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants