Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Use platform detection from Flutter web engine. #147346

Merged
merged 3 commits into from May 7, 2024
Merged

[web] Use platform detection from Flutter web engine. #147346

merged 3 commits into from May 7, 2024
+68 −37

Commits on May 7, 2024

  1. [web] Use platform detection from Flutter web engine.

    @ditman
    ditman committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c8b88a3 View commit details
    Browse the repository at this point in the history

  2. Incorporated reviewer feedback: 

    * Extract the OperatingSystem -> TargetPlatform conversion to a
  function.
  * Make the switch expression exhaustive.
* Add a special section to the _testPlatform getter so it takes into
  account the web_ui overrides.
* Added browser-only unit-test.
    @ditman
    ditman committed May 7, 2024
    Configuration menu
    Copy the full SHA
    251e2a0 View commit details
    Browse the repository at this point in the history

  3. Fix incomplete comments.

    @ditman
    ditman committed May 7, 2024
    Configuration menu
    Copy the full SHA
    506e055 View commit details
    Browse the repository at this point in the history