Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden dependencies on the default LocalPlatform #147342

Merged
merged 1 commit into from May 9, 2024

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 24, 2024

This is part 13 of a broken down version of the #140101 refactor.

This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.

This is part 13 of a broken down version of the flutter#140101 refactor.

This only makes one dependency explicit. Further PRs will do the same for other dependencies, until these APIs have no hidden dependencies.
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 24, 2024
@Hixie
Copy link
Contributor Author

Hixie commented Apr 24, 2024

FWIW, I made no effort to keep the order of parameters sane here. They're already a mess and I have a TODO to do a refactor sweep later that does nothing but reorder arguments/parameters/fields to be consistent.

@goderbauer goderbauer requested a review from Piinks April 30, 2024 22:16
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@Hixie Hixie merged commit e1e742a into flutter:master May 9, 2024
71 checks passed
@Hixie Hixie deleted the golden_refactor_journey_13 branch May 9, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants