New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kotlinOptions jvmTarget to templates #147326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to say this is out of scope for this pr but I think we should have a variable like we do for minimum api level that is referenced for java version support and use that variable for both the java and kotlin versions.
This sounds like a good idea to me. Example: android {
namespace "com.example.example_huy"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileOptions {
sourceCompatibility flutter.jvmTargetVersion
targetCompatibility flutter.jvmTargetVersion
}
kotlinOptions {
jvmTarget = flutter.jvmTargetVersion
}
...
} but yeah, it can land in a different PR |
I think this is a good idea. I filed #147932 |
Adds jvmTarget to gradle templates.
Fixes #147185.
Interestingly, we already had this in many of our examples/tests, see search results here https://github.com/search?q=repo%3Aflutter%2Fflutter%20jvmTarget&type=code.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.