New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropdown menu keyboard navigation #147285
Fix dropdown menu keyboard navigation #147285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
I spotted some minor indentation issues.
cc @QuncCccccc who has a great knowledge of this widget.
Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr>
This reverts commit a965deb.
I didn't know using the "add suggestion to batch" on Github would break the CLA check. Do I need to close this PR and create a new one? |
I will close this PR and move to #147294 because CLA breaks are difficult to fix |
Fix #147253 Fix #147516 Resubmitted #147285 because I accidentally added reviewer as contributor in a commit by using Github "add suggestion to batch". Which causing CLA check to fail and I cannot revert it. I use exact match of label instead of contains to minimise possible change in actual user search. I added the new test after the original keyboard navigation test to avoid merge conflict with another incoming PR. Let me know if I need to make any changes. Sorry for the inconvenience, I am new to the process.
Fix #147253
I use exact match of label instead of
contains
to minimise possible change in actual user search.I added the new test after the original keyboard navigation test to avoid merge conflict with another incoming PR.
Let me know if I need to make any changes.
Move to #147294 because I accidentally added reviewer as contributor in a commit by using Github "add suggestion to batch". Which causing CLA check to fail and it cannot be reverted.
Pre-launch Checklist
///
).