New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wide DatePicker
input mode button padding for Material 3
#147236
Merged
auto-submit
merged 1 commit into
flutter:master
from
TahaTesser:date_input_mode_button_padding
Apr 29, 2024
Merged
Fix wide DatePicker
input mode button padding for Material 3
#147236
auto-submit
merged 1 commit into
flutter:master
from
TahaTesser:date_input_mode_button_padding
Apr 29, 2024
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
flutter/packages/flutter repository. See also f: labels.
f: material design
flutter/packages/flutter/material repository.
labels
Apr 23, 2024
hangyujin
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TahaTesser
force-pushed
the
date_input_mode_button_padding
branch
3 times, most recently
from
April 26, 2024 06:58
b3e5546
to
debebc5
Compare
TahaTesser
force-pushed
the
date_input_mode_button_padding
branch
from
April 29, 2024 07:25
debebc5
to
daa0e7f
Compare
Checked the google testing failures here, there is a small expected screenshot change. 👍 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 30, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 30, 2024
flutter/flutter@db8c475...b597dd2 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c1517bbf555 to 0ce67714ce4c (1 revision) (flutter/flutter#147585) 2024-04-30 engine-flutter-autoroll@skia.org Roll Packages from 87a7c51 to cc47b06 (5 revisions) (flutter/flutter#147580) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1a6ef9957b24 to 2c1517bbf555 (1 revision) (flutter/flutter#147579) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 64877c08661d to 1a6ef9957b24 (1 revision) (flutter/flutter#147576) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1d62704cb3d2 to 64877c08661d (1 revision) (flutter/flutter#147567) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from aace42365fc7 to 1d62704cb3d2 (2 revisions) (flutter/flutter#147566) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea6343846c62 to aace42365fc7 (2 revisions) (flutter/flutter#147563) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from c519e9dd182b to ea6343846c62 (1 revision) (flutter/flutter#147560) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27bb23221305 to c519e9dd182b (1 revision) (flutter/flutter#147557) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93ccb9ab2cda to 27bb23221305 (2 revisions) (flutter/flutter#147556) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from c093562677fa to 93ccb9ab2cda (1 revision) (flutter/flutter#147553) 2024-04-29 21270878+elliette@users.noreply.github.com Bump dependencies in Flutter (flutter/flutter#147546) 2024-04-29 amirpanahandeh@yahoo.com Add configurable hitTestBehavior to Scrollable (flutter/flutter#146403) 2024-04-29 tessertaha@gmail.com Fix wide `DatePicker` input mode button padding for Material 3 (flutter/flutter#147236) 2024-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13c7ac9376a5 to c093562677fa (1 revision) (flutter/flutter#147547) 2024-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5165c711771c to 13c7ac9376a5 (1 revision) (flutter/flutter#147542) 2024-04-29 engine-flutter-autoroll@skia.org Roll Packages from dd01140 to 87a7c51 (2 revisions) (flutter/flutter#147539) 2024-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 399837d38807 to 5165c711771c (2 revisions) (flutter/flutter#147537) 2024-04-29 zeqinjie@qq.com [Fix]: showDateRangePicker with "large" helpText cutoffs the save button (flutter/flutter#146049) 2024-04-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 752b146df767 to 399837d38807 (10 revisions) (flutter/flutter#147532) 2024-04-29 tessertaha@gmail.com Add ability to disable `FloatingActionButton` scale and rotation animations using `FloatingActionButtonAnimator.noAnimation` (flutter/flutter#146126) 2024-04-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions) (#147495)" (flutter/flutter#147502) 2024-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 752b146df767 to f4c20e97e6aa (2 revisions) (flutter/flutter#147495) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Wide
DatePickerDialog
"Switch to input" button has no margin from dialog sideDescription
Currently, there is no material design token for the input mode button padding. This PR fixes the padding by taking date picker side padding values into account.
Code sample
expand to view the code sample
Before
After
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.