New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added revertFlutterImage call in integration_tests #142166
base: master
Are you sure you want to change the base?
fix: added revertFlutterImage call in integration_tests #142166
Conversation
…b.com/YukiAttano/flutter_ into integration_test/revert_flutter_image
I think you should fix takeScreenshot to do the right thing and not extend the API surface area. |
@johnmccutchan that is indeed a point. It would be far simpler for any user if that function would do everything that is required to get that screenshot. According to the existing function documentation, it is not possible to do it like you suggested.
That pumping is made in the WidgetTester class which seems to be out of scope of the Binding class, as i suppose. |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Implemented the Integration test function "revertFlutterImage()* that is missing for 3 years.
Edit:
To add some context:
The "IntegrationTestWidgetsFlutterBinding" Class provides a function called "takeScreenshot".
This function requires to call "convertFlutterSurfaceToImage" on Android devices to work.
That function states in it's documentation that you have to call "revertFlutterImage", after taking a screenshot, to further use your integration test.
The mentioned function was never publicly available but used only in the "addTeadDown" callback.
This PR adds the missing "revertFlutterImage" as a call to the API for people to use in their integration tests.
Issue List
Pre-launch Checklist
///
).