[$RELEASE_BRANCH-cp] Cherry pick #139505
Closed
[$RELEASE_BRANCH-cp] Cherry pick #139505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
XilaiZhang
force-pushed
the
create-pull-request/patch
branch
from
85312dc
to
413b36e
Compare
github-actions
bot
added
the
tool
fluttergithubbot
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is opened against a release branch.
To request a cherry pick of a commit, please fill in the form below. (Questions with an asterisk are required.)
To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.
A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.
Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers
See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples (Bug fix, feature, docs update, ...)
My Answer:
Impacted Users: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
My Answer:
impact_description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
My Answer:
Workaround: Is there a workaround for this issue?
My Answer:
Risk: What is the risk level of this cherry-pick?
My Answer:
Test Coverage: Are you confident that your fix is well-tested by automated tests?
My Answer:
Validation Steps: What are the steps to validate that this fix works?
My Answer: