[$RELEASE_BRANCH-cp] Cherry pick #139405
Closed
[$RELEASE_BRANCH-cp] Cherry pick #139405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
XilaiZhang
force-pushed
the
create-pull-request/patch
branch
from
5d80a5b
to
85312dc
Compare
github-actions
bot
added
the
tool
fluttergithubbot
approved these changes
Dec 2, 2023
|
The template looks very wrong, i will look more into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Request a cherry-pick
description: As a contributor, you would like to request that a feature be cherry-picked into a release.
title: '[CP] <title>'
labels: ['cp: review']
body:
id: issue_link
attributes:
label: Issue Link
description: What is the link to the issue this cherry-pick is addressing?
validations:
required: true
id: commit_hash
attributes:
label: Commit Hash
description: What is the shortened commit hash that has been merged to master/main?
validations:
required: true
id: Target
attributes:
label: Target
description: Should this be cherry-picked to beta or stable?
options:
- stable
- beta
validations:
required: true
id: pr_link
attributes:
label: PR Link
description: >-
Link to an open PR that cherrypick's this into the target release branch.
The current branches can be found under release-caniddate-branch.version for beta and stable
validations:
required: true
id: changelog_description
attributes:
label: Changelog Description
description: >-
Explain this CP in one line that is accessible to most Flutter developers
See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples
validations:
required: true
id: impacted_users
attributes:
label: Impacted Users
description: Approximately who will hit this issue (ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature)?
validations:
required: true
id: impact_description
attributes:
label: Impact Description
description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
validations:
required: true
id: workaround
attributes:
label: Workaround
description: Is there a workaround for this issue?
validations:
required: true
id: risk
attributes:
label: Risk
description: What is the risk level of this cherry-pick?
options:
- low
- medium
- high
validations:
required: true
id: test_coverage
attributes:
label: Test Coverage
description: Are you confident that your fix is well-tested by automated tests?
options:
- "yes"
- "no"
validations:
required: true
id: fix_steps
attributes:
label: Validation Steps
description: What are the steps to validate that this fix works?