Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadowColor and surfaceTintColor to Dialog and DialogTheme. #108405

Merged
merged 3 commits into from Jul 28, 2022
Merged

Add shadowColor and surfaceTintColor to Dialog and DialogTheme. #108405

merged 3 commits into from Jul 28, 2022

Conversation

darrenaustin
Copy link
Contributor

Currently there is no way to configure the drop shadow and/or the surface tint overlay color used by dialogs. This PR adds exposes for the shadowColor and surfaceTintColor used by Dialog's underlying Material widget. It also adds these properties to DialogTheme so they can be configured using themes.

Fixes: #107423

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jul 27, 2022
@TahaTesser TahaTesser self-requested a review July 27, 2022 06:18
TahaTesser
TahaTesser approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guidezpl
guidezpl requested changes Jul 27, 2022
View reviewed changes
packages/flutter/lib/src/material/dialog.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/dialog.dart Outdated Show resolved Hide resolved
HansMuller
HansMuller approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/dialog.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/dialog.dart Outdated Show resolved Hide resolved
guidezpl
guidezpl approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@darrenaustin darrenaustin merged commit 523b600 into flutter:master Jul 28, 2022
@darrenaustin darrenaustin deleted the dialog_shadow_color branch July 28, 2022 21:54
CaseyHillers added a commit that referenced this pull request Jul 29, 2022
@CaseyHillers
Revert "Add shadowColor and surfaceTintColor to Dialog and DialogThem…
46897d8 
…e. (#108405)"

This reverts commit 523b600.
@CaseyHillers CaseyHillers mentioned this pull request Jul 29, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
523b600 Add shadowColor and surfaceTintColor to Dialog and DialogThem…
61fb180 
…e. (flutter/flutter#108405)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2022
@engine-flutter-autoroll
523b600ef Add shadowColor and surfaceTintColor to Dialog and DialogTh…
84412d2 
…eme. (flutter/flutter#108405)
@darrenaustin darrenaustin mentioned this pull request Aug 1, 2022
Merged
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@darrenaustin @camsim99
Add shadowColor and surfaceTintColor to Dialog and DialogTheme. (flut…
a6dbcf0 
…ter#108405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@guidezpl guidezpl guidezpl approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shadowColor and surfaceTintColor to Dialog and DialogTheme
4 participants
@darrenaustin @HansMuller @guidezpl @TahaTesser