Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextStyle support different inherit lerp #103896

Closed
wants to merge 1 commit into from

Conversation

xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented May 16, 2022

Fixes #103864
Fixes #89947
Fixes #70281
Fixes #43358
Fixes #40514

I can not find why we do not support different inherit lerp, so try to support to see if this will break something.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 16, 2022
@rydmike
Copy link
Contributor

rydmike commented May 18, 2022

@xu-baolin, agreed, I think it should work too (I had forgotten that I even demonstrated that in #89947 - lol), so yes I could not see a reason why not either. But if it does not for some reason work OK, I think in that case the text style could just be changed without lerping, document that that is how it is when you do that. It is a rather rare use case. It would be much better than current assert error.

@LongCatIsLooong
Copy link
Contributor

There's a similar attempt to fix #43358.

See this comment: #43470 (comment)

This will lead to really ugly transitions. I think we should instead fix our defaults so this doesn't become a problem.

@xu-baolin xu-baolin closed this May 25, 2022
@rydmike
Copy link
Contributor

rydmike commented May 28, 2022

@LongCatIsLooong Since this was apparently rejected, what is the solution and when? Have things a bit on hold that needs this to work. The use case is being able to toggle theme between correct M2 2018 Typography and new M3 2021 Typography without the issue current behaviour has, as shown here #103864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment