Proposal: add more details to message shown when the tool exits because it's unable to run adb

[andrewkolos]

Occasionally, the Flutter daemon hosted by Visual Studio code on my machine will terminate unexpectedly. The last log message will look something like this:

[{"event":"daemon.logMessage","params":{"level":"error","message":"Unable to run \"adb\", check your Android SDK installation and ANDROID_HOME environment variable: /Users/andrewkolos/Library/Android/sdk/platform-tools/adb"}}]

From the fact that this only happens occasionally (1-3 times a week despite working on the flutter/flutter repo full-time), and the fact that I can normally invoke adb from my terminal just fine, I conclude that the reason for this crash is not something trivial (i.e. adb is not installed.) I think we should augment this crash message to include more useful information so that this can be investigated further.

Relevant code:

flutter/packages/flutter_tools/lib/src/android/android_device_discovery.dart

Lines 64 to 86 in 26e379e

	@override
	Future<List<Device>> pollingGetDevices({ Duration? timeout }) async {
	if (_doesNotHaveAdb()) {
	return <AndroidDevice>[];
	}
	String text;
	try {
	text = (await _processUtils.run(<String>[_androidSdk!.adbPath!, 'devices', '-l'],
	throwOnError: true,
	)).stdout.trim();
	} on ProcessException catch (exception) {
	throwToolExit(
	'Unable to run "adb", check your Android SDK installation and '
	'$kAndroidHome environment variable: ${exception.executable}',
	);
	}
	final List<AndroidDevice> devices = <AndroidDevice>[];
	_parseADBDeviceOutput(
	text,
	devices: devices,
	);
	return devices;
	}

I propose we augment the throwToolExit call to include the exception's message.

[andrewkolos]

Arguably related: #144902

[guidezpl]

Ah I see you're also affected, #125971

[andrewkolos]

Ah I see you're also affected, #125971

Oh cool, I'll close this as a duplicate of #125971