Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadowColor and surfaceTintColor to Dialog and DialogTheme #107423

Closed
darrenaustin opened this issue Jul 11, 2022 · 3 comments · Fixed by #108405, #108718 or #110624
Closed

Add shadowColor and surfaceTintColor to Dialog and DialogTheme #107423

darrenaustin opened this issue Jul 11, 2022 · 3 comments · Fixed by #108405, #108718 or #110624
Assignees
Labels
customer: money (g3) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression

Comments

@darrenaustin
Copy link
Contributor

darrenaustin commented Jul 11, 2022

Internal: b/238831308

Currently there is no way to configure the shadow color or surface tint color for Dialogs. We should add these properties to the Dialog constructors as well as the DialogTheme and update the defaults for M3 to set these appropriately.

@darrenaustin darrenaustin self-assigned this Jul 11, 2022
@darrenaustin darrenaustin added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 11, 2022
@rydmike
Copy link
Contributor

rydmike commented Jul 13, 2022

Thanks, this will certainly help with all the Dialogs currently getting no elevation when opting in on M3, which happens due to Material's new default behaviour in M3, as mentioned and demonstrated here #107190.

There will still be a lot of Material using Flutter SDK widgets left after this is fixed, that are still affected by the new default Material elevation behaviour when opting in on M3.

Plus the needed extra effort to migrate custom composed widgets using Material, to be able opt in on M3 will remain as well.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
@darrenaustin darrenaustin reopened this Sep 1, 2022
@darrenaustin
Copy link
Contributor Author

The original PR had to be reverted, so reopening this. It should be fixed with #110624.

@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P2 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer: money (g3) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression
Projects
None yet
3 participants