Skip to content

Commit

Permalink
Add --no-clean flag to pod lint test
Browse files Browse the repository at this point in the history
  • Loading branch information
jmagman committed Sep 8, 2021
1 parent e36c3a7 commit 398921e
Showing 1 changed file with 34 additions and 1 deletion.
35 changes: 34 additions & 1 deletion dev/devicelab/bin/tasks/plugin_lint_mac.dart
Expand Up @@ -5,6 +5,7 @@
import 'dart:io';

import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/framework/host_agent.dart';
import 'package:flutter_devicelab/framework/task_result.dart';
import 'package:flutter_devicelab/framework/utils.dart';
import 'package:path/path.dart' as path;
Expand All @@ -25,7 +26,7 @@ Future<void> main() async {
final String integrationTestPackage = path.join(flutterRoot, 'packages', 'integration_test');
final String iosintegrationTestPodspec = path.join(integrationTestPackage, 'ios', 'integration_test.podspec');

await exec(
final int lintResult = await exec(
'pod',
<String>[
'lib',
Expand All @@ -34,11 +35,43 @@ Future<void> main() async {
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
'--use-libraries',
'--verbose',
'--no-clean',
],
environment: <String, String>{
'LANG': 'en_US.UTF-8',
},
canFail: true,
);
// https://github.com/flutter/flutter/issues/89626
if (lintResult != 0) {
final Directory systemTemp = Directory.systemTemp;
print('Found temp directory ${systemTemp.path}');
final Iterable<Directory> lintDirectories = Directory.systemTemp
.listSync()
.whereType<Directory>()
.where((Directory tempDirectory) => path.basename(tempDirectory.path).contains('CocoaPods-Lint'));
if (lintDirectories.isNotEmpty) {
final Directory lintDirectory = lintDirectories.first;
print('Found lint directory ${lintDirectory.path}');
final Directory? dumpDirectory = hostAgent.dumpDirectory;
if (dumpDirectory != null) {
final String zipPath = path.join(dumpDirectory.path,
'lint-${DateTime.now().toLocal().toIso8601String()}.zip');
return exec(
'zip',
<String>[
'-r',
'-9',
zipPath,
lintDirectory.path,
],
canFail: true, // Best effort to get the logs.
);
}
}

throw TaskResult.failure('Lint failed');
}

final String macosintegrationTestPodspec = path.join(integrationTestPackage, 'integration_test_macos', 'macos', 'integration_test_macos.podspec');
await exec(
Expand Down

0 comments on commit 398921e

Please sign in to comment.