[Impeller] make default glyph atlas size much bigger. #52787
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
| const ISize& max_texture_size) { | ||
| static constexpr auto kMinAtlasSize = 8u; |
There was a problem hiding this comment.
lol, thats comically small. I think this was from a time when the glyph atlas was per render pass.
There was a problem hiding this comment.
not even a single emoji!
|
Golden file changes are available for triage from new commit, Click here to view. |
|
The goldens on this are incredibly confusing. |
|
I guess shrink the atlas size until I no longer see pink? Does that work lol |
…e into larger_default_atlas
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
added
the
autosubmit
…148369) flutter/engine@d35a1a6...bf1c6da 2024-05-15 jonahwilliams@google.com [Impeller] make default glyph atlas size much bigger. (flutter/engine#52787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now that we no longer have a full CPU copy of the glyph atlas, it should be cheaper to make a larger initial atlas to reduce churn from resizing seen in applications like flutter/flutter#138798
Requires #52746