-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] migrated one test over from aiks to dl #52786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it blends this works for me.
LGTM
(The test rewrite isn't quite right yet, but the infra is hooked up) |
I think this should be fixed, however I'm not sure if the goldens are updating. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
alright, generated diff and confirmed its working! |
…148338) flutter/engine@7bf8657...08b44d9 2024-05-14 30870216+gaaclarke@users.noreply.github.com [Impeller] migrated one test over from aiks to dl (flutter/engine#52786) 2024-05-14 jason-simmons@users.noreply.github.com [Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage (flutter/engine#52790) 2024-05-14 magder@google.com Refactor Semantics in preparation for ARC migration (flutter/engine#52729) 2024-05-14 zanderso@users.noreply.github.com Rolls in buildroot with stack protection flag (flutter/engine#52774) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
A redo of #52711 that maintains our existing testing patterns.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.