Re-add MipFilter::kBase, but keep kNearest as the default.
#52779
Conversation
|
|
||
| switch (mip_filter.value()) { | ||
| MipFilter mip_filter = MipFilter::kNearest) { | ||
| switch (mip_filter) { |
There was a problem hiding this comment.
@chinmaygarde to confirm, I think I remember this being weird because I had to fake support no mips.
There was a problem hiding this comment.
I suspect we still need to treat an unspecified param as kBase here
There was a problem hiding this comment.
PTAL again, made some adjustments
| // TODO(https://github.com/flutter/flutter/issues/148253): | ||
| // `MipFilter::kNearest` is the default value for mip filters, as it | ||
| // cooresponds with the framework's `FilterQuality.low`. If we ever change the | ||
| // default filter quality, we should update this function to match. | ||
| sampler_desc.mip_filter = MipFilter::kNearest; |
There was a problem hiding this comment.
Its probably correct for this to be changed to base since we don't generate mipmaps for glyph atlas (as they glyphs are generated at exact scales)
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Oops, definitely broke OpenGLES. Will revisit tomorrow morning. |
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| #include "impeller/renderer/backend/gles/sampler_gles.h" | |||
|
|
|||
| #include "GLES3/gl3.h" | |||
There was a problem hiding this comment.
I think you don't want this include here
|
Golden file changes are available for triage from new commit, Click here to view. |
|
@chinmaygarde: I'm going to merge this, but comments still welcome after the fact. |
matanlurey
added
the
autosubmit
…148428) flutter/engine@bf1c6da...41b86b5 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from 475559da107d to b9a304eb05d2 (1 revision) (flutter/engine#52857) 2024-05-15 magder@google.com Migrate TextInputSemanticsObject to ARC (flutter/engine#52785) 2024-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from NbCi2ETfLHPLLB-JV... to Ftw7GopnudHydGS1y... (flutter/engine#52853) 2024-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 7d9de0c0b231 to f773d45634ed (2 revisions) (flutter/engine#52854) 2024-05-15 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#52826) 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4a7419d662d5 to 475559da107d (5 revisions) (flutter/engine#52848) 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from a9ba7411d4b2 to 4a7419d662d5 (1 revision) (flutter/engine#52844) 2024-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 1eec9de2f9c6 to 7d9de0c0b231 (1 revision) (flutter/engine#52841) 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from b3aadd56d187 to a9ba7411d4b2 (1 revision) (flutter/engine#52839) 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from c0caf10486ce to b3aadd56d187 (3 revisions) (flutter/engine#52837) 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from fad584324d85 to c0caf10486ce (1 revision) (flutter/engine#52835) 2024-05-15 magder@google.com Migrate SemanticsObject and FlutterSemanticsScrollView to ARC (flutter/engine#52824) 2024-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 0b77fbab8cf5 to 1eec9de2f9c6 (1 revision) (flutter/engine#52833) 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from d0d87c26b489 to fad584324d85 (1 revision) (flutter/engine#52831) 2024-05-15 matanlurey@users.noreply.github.com Re-add `MipFilter::kBase`, but keep `kNearest` as the default. (flutter/engine#52779) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from NbCi2ETfLHPL to Ftw7GopnudHy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter/flutter#147259.
Changes:
kNearestis used consistentlykBasekNearestkBasein the Metal, Vulkan, and OpenGLES backendsExpecting an update to the
dart_ui_filter_quality_nonegolden file:For breadcrumbs around the mapping, see flutter/flutter#148253.