[web] Expose browser_detection through ui_web. #52380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mdebbar
approved these changes
May 1, 2024
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
Updates documentation according to review comments.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2024
…147693) flutter/engine@3087ec1...78dced5 2024-05-02 bdero@google.com et phone home (flutter/engine#52506) 2024-05-02 ditman@gmail.com [web] Expose browser_detection through ui_web. (flutter/engine#52380) 2024-05-02 jonahwilliams@google.com [Impeller] remove incremental allocation during filled path tessellation. (flutter/engine#52401) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
> [!IMPORTANT] > Requires the following engine PR: > * flutter/engine#52380 > ---- This PR refactors Flutter `foundation`'s library `platform` for the web with the same code we use to detect platforms in the engine. ## Issues * Fixes: #128943 ## Testing Demo app deployed here: * https://dit-browser-detect.web.app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the core of
browser_detection.dartto a location indart:ui_webso it can be used by apps and plugins.In order for the code to be a little bit tidier in ui_web, it's encapsulated in a singleton instance that can be accessed through
BrowserDetection.instanceor a top level globalbrowserindart:ui_web.Issues
Tests
Updated affected tests. Mostly the update was to call the methods from
web_ui.browser.methodNamerather than a global scope. Also split the tests for this module in two files:engine_browser_detect_test.dart- with the tests specific to the engine (capability detection, etc...)browser_detect_test.dart- only the tests pertaining to the "core" of the library.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.