-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set deep linking flag to true by default #52350
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
shell/platform/android/test/io/flutter/embedding/android/FlutterFragmentActivityTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any mechanism for the framework to say whether pushRouteInformation
successfully pushed a known route? If so, it might be better to return that (the non-deprecated version of this API is async https://developer.apple.com/documentation/uikit/uiapplication/1648685-openurl, so we could migrate onto that)
@jmagman yes, framework method But i think migrating to a non-deprecated async API will be a separated issue and a separated PR from this flag change . |
I'm not really concerned that it's deprecated, more that this PR changes behavior where this method will be returning true even when there's no deep linking set up, and it's not opted into. |
Looks like the framework currently sends Maybe we can do
|
Why does iOS need to listen for |
cause didPushRouteInformation's return value is on the framework side, i thought the way for engine to get it is through a method channel, so the ios |
Can you make The didUpdateRouteInformation is to report current route in framework to engine. It will be smart enough to check whether the current route/state with the one in engine is the same or not before sending the request. So it is not guaranteed that |
That being said we should probably add the feature to reject deeplink in go_router, right now it just swallow all and handle error on the framework side |
Can you make _handleNavigationInvocation to return a future of boolean to indicate whether any of the widgetbindObserver.didpushRouteInformation has handled the route or not? >> noted, I will do that, thanks! |
@hangyujin Are you wanting to make more changes or is this ready for revew? |
@reidbaker i want to land flutter/flutter#147901 and #52643 first. |
…r any of the observer has handled the route or not (#147901) follow up on comments on flutter/engine#52350
doc: flutter.dev/go/deep-link-flag-migration
Action item: make sure customers are aware of this change before merging this PR.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.