Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove schedules from scorecards. #31337

Merged
merged 1 commit into from Feb 9, 2022
Merged

Remove schedules from scorecards. #31337

merged 1 commit into from Feb 9, 2022

Conversation

godofredoc
Copy link
Contributor

Scorecards does not work properly on schedules. Removing the scheduled
run as we are running on every PR.

Bug: flutter/flutter#98058

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove schedules from scorecards.
9f8920f 
Scorecards does not work properly on schedules. Removing the scheduled
run as we are running on every PR.

Bug: flutter/flutter#98058
keyonghan
keyonghan approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 8, 2022
@fluttergithubbot fluttergithubbot merged commit bb563d9 into flutter:main Feb 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
bb563d9 Remove schedules from scorecards. (flutter/engine#31337)
e22d75e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
bb563d9 Remove schedules from scorecards. (flutter/engine#31337)
5ed635d
@godofredoc godofredoc deleted the remove_schedule branch January 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@godofredoc @keyonghan @fluttergithubbot