Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postsubmit rerun based on checkrun #3675

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix postsubmit rerun based on checkrun #3675

wants to merge 5 commits into from

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan marked this pull request as draft April 19, 2024 05:06
@keyonghan keyonghan mentioned this pull request Apr 22, 2024
Open
@keyonghan keyonghan force-pushed the postsubmit_checkrun_rerun_fix branch from 04e9ded to 67adf4b Compare April 22, 2024 20:29
@keyonghan keyonghan marked this pull request as ready for review April 22, 2024 21:04
@ricardoamador
Copy link
Contributor

ricardoamador commented Apr 22, 2024 •
edited by keyonghan

Just a heads up that this will conflict with the buildbucket changes. If we can, can we wait for those changes to land? I can help convert this afterwards if you like.

SG. /cc @stuartmorgan I will wait for the Buildbucket V2 changes to land before merging this.

ricardoamador
ricardoamador reviewed Apr 22, 2024
View reviewed changes
app_dart/lib/src/service/luci_build_service.dart
}
tags['current_attempt'] = <String>[(taskDocument.attempts!).toString()];
log.info('Updated input ${build.input!} tags $tags');
final BatchRequest request = BatchRequest(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I am not understanding, is this really a postsubmit task that is run in presubmit for packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postsubmit task is for postsubmit CI. It shares the same github UI for checkrun view. You can view the postsubmit ones:
Screenshot 2024-04-22 at 3 55 07 PM

@keyonghan
Copy link
Contributor Author

Validated this works with https://github.com/flutter/packages/runs/24162936475.
Manually reran https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20android_platform_tests_shard_6%20stable/1110/infra, and it successfully updated database and the GitHub checkrun.

ricardoamador
ricardoamador approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoamador ricardoamador ricardoamador approved these changes

@sealesj sealesj sealesj approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@keyonghan @ricardoamador @sealesj