refactor: follow up on PR comments

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
fluidd-core · Aug 1, 2022 · faa8e01 · faa8e01
1 parent 7cceb70
commit faa8e01
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/src/App.vue b/src/App.vue
@@ -215,21 +215,22 @@ export default class App extends Mixins(StateMixin) {
       this.flashMessage.open = true
     })
 
-    const clearNodes = (item: Element) => {
-      const parentElement = item.parentElement
-
-      if (parentElement) {
-        parentElement.removeChild(item)
-      }
-    }
-
-    const legacyFavIcons = document.querySelectorAll("link[rel*='icon'][type='image/png']")
+    const legacyElementsSelectors = [
+      "link[rel*='icon'][type='image/png']",
+      "meta[name='theme-color']"
+    ]
 
-    legacyFavIcons.forEach(clearNodes)
+    for (const legacyElementsSelector of legacyElementsSelectors) {
+      const legacyElements = document.querySelectorAll(legacyElementsSelector)
 
-    const legacyThemeColor = document.querySelectorAll("meta[name='theme-color']")
+      legacyElements.forEach(item => {
+        const parentElement = item.parentElement
 
-    legacyThemeColor.forEach(clearNodes)
+        if (parentElement) {
+          parentElement.removeChild(item)
+        }
+      })
+    }
   }
 
   handleToolsDrawerChange () {