Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable assertion extenions cleanup #936

Conversation

krajek
Copy link
Contributor

@krajek krajek commented Oct 3, 2018

Two main topics of the PR:

  • Introduce regions for NumericAssertionsExtensions, one for each method group
  • Extract repeated code from each method group

I would like that to be merged before I will tackle extension of NotBeEquivalentTo for nullable subject and expected value (I mean folloup of #934).

@krajek krajek force-pushed the nullable_assertion_extenions_cleanup branch from c1e6d14 to bf045c1 Compare October 4, 2018 18:20
@krajek
Copy link
Contributor Author

krajek commented Oct 5, 2018

Ready to merge.

@dennisdoomen dennisdoomen merged commit 19e17a7 into fluentassertions:master Oct 5, 2018
@krajek krajek deleted the nullable_assertion_extenions_cleanup branch October 5, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants