Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve enum comparison assert messages #923

Merged
merged 13 commits into from Sep 27, 2018
Merged

Improve enum comparison assert messages #923

merged 13 commits into from Sep 27, 2018

Commits on Sep 24, 2018

  1. Improve assertion message after comparing enums by value

    @krajek
    krajek committed Sep 24, 2018
    Copy the full SHA
    048e810 View commit details
    Browse the repository at this point in the history

  2. Extract enum handling methods, by-value and by-name

    @krajek
    krajek committed Sep 24, 2018
    Copy the full SHA
    08085dd View commit details
    Browse the repository at this point in the history

  3. Improve assertion message for comparing enums by name

    @krajek
    krajek committed Sep 24, 2018
    Copy the full SHA
    a11c5ae View commit details
    Browse the repository at this point in the history

  4. Rename EnumeThree to EnumThree

    @krajek
    krajek committed Sep 24, 2018
    Copy the full SHA
    2330d24 View commit details
    Browse the repository at this point in the history

  5. Unquote enum values in assertion message

    @krajek
    krajek committed Sep 24, 2018
    Copy the full SHA
    55074e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. Add "by name" and "by value", respectively, to enum assertion message

    @krajek
    krajek committed Sep 25, 2018
    Copy the full SHA
    d1a3137 View commit details
    Browse the repository at this point in the history

  2. PrintDecimal helper method accepting non-nullable

    @krajek
    krajek committed Sep 25, 2018
    Copy the full SHA
    114ad8c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into better_enum_comparing

    @krajek
    krajek committed Sep 25, 2018
    Copy the full SHA
    0eed936 View commit details
    Browse the repository at this point in the history

  4. Use lazy FailWith for enum assertions

    @krajek
    krajek committed Sep 25, 2018
    Copy the full SHA
    68ecb20 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2018

  1. Reword enum assertion: "to be" -> "to equal"

    @krajek
    krajek committed Sep 26, 2018
    Copy the full SHA
    d022757 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2018

  1. Few changes after code reviews

    @krajek
    krajek committed Sep 27, 2018
    Copy the full SHA
    47231e4 View commit details
    Browse the repository at this point in the history

  2. Fix case of comparing null subject with enum

    @krajek
    krajek committed Sep 27, 2018
    Copy the full SHA
    49134d1 View commit details
    Browse the repository at this point in the history

  3. Use {context:enum} instead of plain text

    @krajek
    krajek committed Sep 27, 2018
    Copy the full SHA
    550ae72 View commit details
    Browse the repository at this point in the history