Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of AllBeEquivalentTo #920

Merged
merged 9 commits into from Sep 26, 2018
Merged

Improve performance of AllBeEquivalentTo #920

merged 9 commits into from Sep 26, 2018

Commits on Sep 19, 2018

  1. Force strinct ordering for collection created by AllBeEquivalentTo. 

    Improves algorithmic complexity from O(n^2) to O(n)
    @krajek
    krajek committed Sep 19, 2018
    Copy the full SHA
    14ff25e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2018

  1. Extract comparison of item for strictly matched collection to new scope

    @krajek
    krajek committed Sep 23, 2018
    Copy the full SHA
    502977c View commit details
    Browse the repository at this point in the history

  2. Extract OrderingRules.IsOrderingStrictFor before the loop 

    I found out during profiling that repeated call to this method
was taking up to 10% of the execution time.
    @krajek
    krajek committed Sep 23, 2018
    Copy the full SHA
    0248f69 View commit details
    Browse the repository at this point in the history

  3. Fail fast after 10 items are detected to be incorrect in `EnumerableE… 

    …quivalencyValidator`
    @krajek
    krajek committed Sep 23, 2018
    Copy the full SHA
    1ed5ecd View commit details
    Browse the repository at this point in the history

  4. Add trace message in case of fast fail comparing enumerable equivalency

    @krajek
    krajek committed Sep 23, 2018
    Copy the full SHA
    5cfc85c View commit details
    Browse the repository at this point in the history

  5. Extract methods from `EnumerableEquivalencyValidator.AssertElementGra… 

    …phEquivalency`
    @krajek
    krajek committed Sep 23, 2018
    Copy the full SHA
    7df628d View commit details
    Browse the repository at this point in the history

  6. Fast fail enumerable equivalency with loose ordering after 10 failed … 

    …items
    @krajek
    krajek committed Sep 23, 2018
    Copy the full SHA
    92c1acc View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2018

  1. Fixes after code reviews

    @krajek
    krajek committed Sep 26, 2018
    Copy the full SHA
    051ade9 View commit details
    Browse the repository at this point in the history

  2. Fix wording in trace message for aborting comparison of collections

    @krajek
    krajek committed Sep 26, 2018
    Copy the full SHA
    dce8193 View commit details
    Browse the repository at this point in the history