Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report mismatch segment for strings of unequal lengths #915

Merged
merged 8 commits into from Sep 20, 2018
Merged

Report mismatch segment for strings of unequal lengths #915

merged 8 commits into from Sep 20, 2018

Commits on Sep 16, 2018

  1. Report mismatch segment for strings of unequal lengths

    @krajek
    krajek committed Sep 16, 2018
    Copy the full SHA
    817f117 View commit details
    Browse the repository at this point in the history

  2. Find correct mismatch index in case of one string being prefix of the… 

    … other
    @krajek
    krajek committed Sep 16, 2018
    Copy the full SHA
    2545fa2 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Add tests for validating equality of empty and not empty string

    @krajek
    krajek committed Sep 17, 2018
    Copy the full SHA
    e63dff9 View commit details
    Browse the repository at this point in the history

  2. Extract method for calculation of mismatch segment for strings of une… 

    …qual lengths
    @krajek
    krajek committed Sep 17, 2018
    Copy the full SHA
    c7748ab View commit details
    Browse the repository at this point in the history

  3. Adjust documentation with new format of assertion message for strings… 

    … of unequal length
    @krajek
    krajek committed Sep 17, 2018
    Copy the full SHA
    d14eca6 View commit details
    Browse the repository at this point in the history

  4. Readability fixes after review

    @krajek
    krajek committed Sep 17, 2018
    Copy the full SHA
    928e283 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Relax few string assertion test constrains regarding message

    @krajek
    krajek committed Sep 18, 2018
    Copy the full SHA
    296dd6e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Prune unnecessary Math.Max, length is always positive anyway

    @krajek
    krajek committed Sep 19, 2018
    Copy the full SHA
    b3063e8 View commit details
    Browse the repository at this point in the history