New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow event monitoring to ignore failing event accessors #2629
Open
ITaluone
wants to merge
16
commits into
fluentassertions:develop
Choose a base branch
from
ITaluone:failing-event-accessors
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow event monitoring to ignore failing event accessors #2629
ITaluone
wants to merge
16
commits into
fluentassertions:develop
from
ITaluone:failing-event-accessors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved methods config options to `EventMonitorOptions`
Fixed wrong Timestamp
ITaluone
changed the title
Failing event accessors
Allow event monitoring to ignore failing event accessors
Apr 22, 2024
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
ITaluone
force-pushed
the
failing-event-accessors
branch
from
April 22, 2024 14:14
1bbac73
to
18ec177
Compare
Pull Request Test Coverage Report for Build 8785957019Details
💛 - Coveralls |
ITaluone
force-pushed
the
failing-event-accessors
branch
from
April 22, 2024 14:29
18ec177
to
e45626c
Compare
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
… the dictionary - Added option to still receive events even when add accessor threw an exception
Updated descriptions to match current the actual behavior
Co-authored-by: IT-VBFK <49762557+IT-VBFK@users.noreply.github.com>
ITaluone
force-pushed
the
failing-event-accessors
branch
from
April 22, 2024 14:36
e45626c
to
030821c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes #1954
Closes #1948
Note: All credits goes to @apazureck!
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome