Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow event monitoring to ignore failing event accessors #2629

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Apr 22, 2024

This finishes #1954

Closes #1948

Note: All credits goes to @apazureck!

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@ITaluone ITaluone changed the title Failing event accessors Allow event monitoring to ignore failing event accessors Apr 22, 2024
Copy link

github-actions bot commented Apr 22, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8785957019

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.566%

Totals Coverage Status
Change from base Build 8692447816: 0.005%
Covered Lines: 12054
Relevant Lines: 12238

💛 - Coveralls

Andreas Pazureck and others added 10 commits April 22, 2024 16:35
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
… the dictionary

- Added option to still receive events even when add accessor threw an exception
Updated descriptions to match current the actual behavior
Co-authored-by: IT-VBFK <49762557+IT-VBFK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions in event accessors fail tests when using .Monitor()
4 participants