Correctly specify nullability of Subject for NumericAssertions

[vbreuss]

Discussion in #2472

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[github-actions]

Qodana for .NET

387 new problems were found

Inspection name	Severity	Problems
Cannot resolve reference in XML comment	🔴 Failure	247
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.	🔴 Failure	66
Ambiguous reference in XML comment	🔴 Failure	4
Keyword 'new' is required	🔴 Failure	1
Redundant using directive	🔶 Warning	46
Usage of <inheritdoc /> is invalid	🔶 Warning	7
Method return value is never used (private accessibility)	🔶 Warning	7
Method with optional or 'params' parameter is hidden by overload	🔶 Warning	1
Unused parameter (private accessibility)	🔶 Warning	1
Inline temporary variable	◽️ Notice	7

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[coveralls]

Pull Request Test Coverage Report for Build 7398628470

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.01%) to 97.452%

---

Totals
Change from base Build 7378622478:	-0.01%
Covered Lines:	11745
Relevant Lines:	11930

---

💛 - Coveralls

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions