Simplify inheritance of SubsequentOrderingAssertions

[vbreuss]

The SubsequentOrderingGenericCollectionAssertions<TCollection, T> is only used as a base class for SubsequentOrderingAssertions. By moving the functionality into the (previously empty) SubsequentOrderingAssertions the inheritance tree can be simplified.

This should also increase the code coverage according to #1823.

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[coveralls]

Pull Request Test Coverage Report for Build 7398640344

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 97.477%

---

Totals
Change from base Build 7378622478:	0.01%
Covered Lines:	11744
Relevant Lines:	11926

---

💛 - Coveralls

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[jnyrup]

I don't know or recall why #1416 used SubsequentOrderingAssertions in GenericCollectionAssertions instead of SubsequentOrderingGenericCollectionAssertions.
The latter retains TCollection whereas the former uses IEnumerable<T> which TCollection is constrained to.

Could we use SubsequentOrderingGenericCollectionAssertions instead of SubsequentOrderingAssertions?

[vbreuss]

Could we use SubsequentOrderingGenericCollectionAssertions instead of SubsequentOrderingAssertions?

I don't have any preference regarding the naming. I was simply wondering why it needed so many levels of inheritance and could find no reason for it. Should I rename SubsequentOrderingAssertions to SubsequentOrderingGenericCollectionAssertions?

[jnyrup]

Could we use SubsequentOrderingGenericCollectionAssertions instead of SubsequentOrderingAssertions?

I don't have any preference regarding the naming. I was simply wondering why it needed so many levels of inheritance and could find no reason for it. Should I rename SubsequentOrderingAssertions to SubsequentOrderingGenericCollectionAssertions?

Not sure I get you.
I didn't mean rename SubsequentOrderingAssertions to SubsequentOrderingGenericCollectionAssertions, but let the relevant assertions in GenericCollectionAssertions return SubsequentOrderingGenericCollectionAssertions instead of SubsequentOrderingAssertions.

[vbreuss]

Not sure I get you.
I didn't mean rename SubsequentOrderingAssertions to SubsequentOrderingGenericCollectionAssertions, but let the relevant assertions in GenericCollectionAssertions return SubsequentOrderingGenericCollectionAssertions instead of SubsequentOrderingAssertions.

That would practically be the same. All methods were in one class and all other classes were empty. I chose SubsequentOrderingAssertions to keep (move all logic inside and remove the inheritance). Alternatively I could keep the logic in SubsequentOrderingGenericCollectionAssertions and replace all references of SubsequentOrderingAssertions with it.

I expected the first change to have less chance of breaking things, as I don't change the return type of existing methods. That was my reason for choosing this way...

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[dennisdoomen]

@jnyrup I think this is waiting for you, isn't it?