Qodana fixes

[IT-VBFK]

First few Qodana "fixes".

Please close safely if it does not suit you :)

Note that I have most likely not covered all "same errors".

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[coveralls]

Pull Request Test Coverage Report for Build 5717365346

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 3 of 4 (75.0%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.007%) to 97.224%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
Src/FluentAssertions/Formatting/DefaultValueFormatter.cs	0	1	0.0%

Totals
Change from base Build 5708086092:	-0.007%
Covered Lines:	12903
Relevant Lines:	13146

---

💛 - Coveralls

[IT-VBFK]

Pretty sure that I would go straight to a closed institution after I am done here 😂

I also pretty sure that this is a never ending story ;)

[IT-VBFK]

To be honest... I'm in doubt whether this sort of changes have an end..

e.g. the latest Quodana run:

I am pretty sure that I have fixed less than 92 problems, but in return we have 92 new ones.

[dennisdoomen]

I am pretty sure that I have fixed less than 92 problems, but in return we have 92 new ones.

Because you touched old code ;-). But this requires tweaking. Not everything should be checked by Quodana.

[IT-VBFK]

Hi

I will close this, because I am not that familiar with the whole codebase 🤔

But I stay attentively on this topic 🙃

[jnyrup]

Ohh... I liked this PR.
I only had some final comments before I was ready to merge it.

[IT-VBFK]

Oh.. in that case.. I will open it again 🫣

[dennisdoomen]

We need to disable the two rules (one only for the test projects).

[dennisdoomen]

It would be nice to use fix-up commits to remove those reversion commits from the PR

[Corniel]

LGTM

[IT-VBFK]

@jnyrup What should we do regarding var-qodana-problems?

[jnyrup]

Suspicious comparison: there is no type in the solution which is inherited from both 'FluentAssertions.Primitives.DateTimeOffsetRangeAssertions' and 'System.DateTimeOffset'

This looks like a bug in Qodana to me.

set { nonSerializable = value; }

I'm fine changing this to => nonSerializable = value;

someObject.Equals(someObject);

Can probably be changed to someObject.Equals(null);

[IT-VBFK]

Suspicious comparison: there is no type in the solution which is inherited from both 'FluentAssertions.Primitives.DateTimeOffsetRangeAssertions' and 'System.DateTimeOffset'

This looks like a bug in Qodana to me.

Ok
I find it really weird, that qodana even takes a feature (https://dotnetfiddle.net/hCSuRg) (which C# doesn't have) into consideration 😂

[IT-VBFK]

var action = () => someDateTimeOffset.Should().BeLessThan(0.Seconds()).Equals(someDateTimeOffset);

Or we change this also to e.g. var action = () => someDateTimeOffset.Should().BeLessThan(0.Seconds()).Equals(null);

[dennisdoomen]

I find it really weird, that qodana even takes a feature (https://dotnetfiddle.net/hCSuRg) (which C# doesn't have) into consideration

It's not just Qodana. Rider is warning about the same issue.

So maybe we can just suppress that inspection for all *.specs files?

[IT-VBFK]

If @jnyrup agrees with that :)

[jnyrup]

Now I understand the issue. Thought it was about the use of var. I'm quite sure it's warning about using Equals on two types, that besides object, type-hierachy-wise are completely disconnected and will probably never return true.

Can we silence the analyzer bu passing null in?

[IT-VBFK]

Let's find out ;)

Edit: Works like a charm :D