Add NotContainEquivalentOf

[ishimko]

Fixes #1287.

IMPORTANT

• The code complies with the Coding Guidelines for C#.
• The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

[jnyrup]

Nice work 👍
Could I ask you to add a line to https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md as well?

[ishimko]

Nice work 👍
Could I ask you to add a line to https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md as well?

Thanks @jnyrup! Should I put it into 6.0.0 section?

[jnyrup]

Thanks @jnyrup! Should I put it into 6.0.0 section?
Yes, the develop branch is what will eventually become 6.0.0.

[ishimko]

@jnyrup sorry, I've accidentally pushed "trim" of release.md. Let me fix this, don't like unnecessary changes.

[ishimko]

@jnyrup thanks for the review! I've reverted trim, it should be good now.

[jnyrup]

I think this could be written as:

if (foundIndices.Count > 0)
{
    Assertion assertion = Execute.Assertion
        .BecauseOf(because, becauseArgs)
        .WithExpectation("Expected {context:collection} {0} not to contain equivalent of {1}{reason}, ", Subject, unexpected)
        .AddReportable("configuration", options.ToString());

    if (foundIndices.Count == 1)
    {
        assertion
            .FailWith("but found one at index {0}.", foundIndices[0])
            .Then
            .ClearExpectation();
    }
...
}

[ishimko]

I tried similar approach earlier and it did not work unfortunately.

Firstly I was surprised that AddReportable is a void method, however I've extracted return value from .WithExpectation and just called AddReportable on it (that's not an issue of course).

The problem I faced is that AddReportable does not work when called outside new AssertionScope(). I'm not familiar with the codebase much, but quick look brought me to conclusion that "With" stuff is only attached on Dispose which seems to be not called on regular non-lazy assertion scope.

Am I missing something? What do you think?

[jnyrup]

I haven't used AddReportable much, so @dennisdoomen might be better to answer this than me.

[ishimko]

Ok thanks.

BTW I added a test with using NotContainEquivalentOf inside AssertionScope: 05b5f66. I did it in a separate commit, because I don't know how this aligns with your testing approach. Looks like it works fine (if I understand "expected" correctly).

[dennisdoomen]

AddReportable was indeed only used by EquivalencyValidator to initialize an AssertionScope within which the entire equivalency engine runs.

[dennisdoomen]

Nothing to add to @jnyrup's comments.

[dennisdoomen]

AddReportable was indeed only used by EquivalencyValidator to initialize an AssertionScope within which the entire equivalency engine runs.

[jnyrup]

@vanashimko I saw you added a test to verify using new AssertionScope().
Unless you have anything else, I'm fine merging this.

[ishimko]

@jnyrup I'm good