Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat enums and their numeric representations in structural object graph comparisons the same #1208

Merged
merged 1 commit into from Jan 1, 2020
Merged

Treat enums and their numeric representations in structural object graph comparisons the same #1208

merged 1 commit into from Jan 1, 2020

Commits on Dec 28, 2019

  1. Fix comparing enums and integers for equality 

    Before fluentassertions#1202 we had an asymmetry where:
* `When_comparing_an_enum_and_a_numeric_for_equality_it_should_not_throw` passed, but
* `When_comparing_a_numeric_and_an_enum_for_equality_it_should_not_throw` failed.

After fluentassertions#1202 both of them failed.

This PR makes them both pass to minimize the change of behavior while fixing the asymmetry.
fluentassertions#1204 has a discussion of how to compare enums, integers and strings.
    @jnyrup
    jnyrup committed Dec 28, 2019
    Copy the full SHA
    734e3e7 View commit details
    Browse the repository at this point in the history