Baleeted TypeDescriptionUtility, per @dennisdoomen.

fluentassertions · Mar 17, 2022 · d2076fd · d2076fd
1 parent 2a4c162
commit d2076fd
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 99 deletions.
diff --git a/Src/FluentAssertions/Common/TypeDescriptionUtility.cs b/Src/FluentAssertions/Common/TypeDescriptionUtility.cs
diff --git a/Src/FluentAssertions/DataColumnCollectionAssertionExtensions.cs b/Src/FluentAssertions/DataColumnCollectionAssertionExtensions.cs
@@ -48,8 +48,8 @@ public static class DataColumnCollectionAssertionExtensions
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
                         "Invalid expectation: Expected {context:column collection} to refer to an instance of " +
-                        "DataColumnCollection{reason}, but found " +
-                        TypeDescriptionUtility.GetDescriptionOfObjectType(assertion.Subject) + ".");
+                        "DataColumnCollection{reason}, but found {0}.",
+                        assertion.Subject);
             }
 
             return new AndConstraint<GenericCollectionAssertions<DataColumn>>(assertion);
@@ -89,8 +89,8 @@ public static class DataColumnCollectionAssertionExtensions
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
                         "Invalid expectation: Expected {context:column collection} to refer to a different instance of " +
-                        "DataColumnCollection{reason}, but found " +
-                        TypeDescriptionUtility.GetDescriptionOfObjectType(assertion.Subject) + ".");
+                        "DataColumnCollection{reason}, but found {0}.",
+                        assertion.Subject);
             }
 
             return new AndConstraint<GenericCollectionAssertions<DataColumn>>(assertion);

diff --git a/Src/FluentAssertions/DataRowCollectionAssertionExtensions.cs b/Src/FluentAssertions/DataRowCollectionAssertionExtensions.cs
@@ -46,8 +46,8 @@ public static class DataRowCollectionAssertionExtensions
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
                         "Invalid expectation: Expected {context:column collection} to refer to an instance of " +
-                        "DataRowCollection{reason}, but found " +
-                        TypeDescriptionUtility.GetDescriptionOfObjectType(assertion.Subject) + ".");
+                        "DataRowCollection{reason}, but found {0}.",
+                        assertion.Subject);
             }
 
             return new AndConstraint<GenericCollectionAssertions<DataRow>>(assertion);
@@ -84,8 +84,8 @@ public static class DataRowCollectionAssertionExtensions
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
                         "Invalid expectation: Expected {context:column collection} to refer to a different instance of " +
-                        "DataRowCollection{reason}, but found " +
-                        TypeDescriptionUtility.GetDescriptionOfObjectType(assertion.Subject) + ".");
+                        "DataRowCollection{reason}, but found {0}.",
+                        assertion.Subject);
             }
 
             return new AndConstraint<GenericCollectionAssertions<DataRow>>(assertion);

diff --git a/Src/FluentAssertions/DataTableCollectionAssertionExtensions.cs b/Src/FluentAssertions/DataTableCollectionAssertionExtensions.cs
@@ -43,8 +43,8 @@ public static class DataTableCollectionAssertionExtensions
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
                         "Invalid expectation: Expected {context:column collection} to refer to an instance of " +
-                        "DataTableCollection{reason}, but found " +
-                        TypeDescriptionUtility.GetDescriptionOfObjectType(assertion.Subject) + ".");
+                        "DataTableCollection{reason}, but found {0}.",
+                        assertion.Subject);
             }
 
             return new AndConstraint<GenericCollectionAssertions<DataTable>>(assertion);
@@ -81,8 +81,8 @@ public static class DataTableCollectionAssertionExtensions
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
                         "Invalid expectation: Expected {context:column collection} to refer to a different instance of " +
-                        "DataTableCollection{reason}, but found " +
-                        TypeDescriptionUtility.GetDescriptionOfObjectType(assertion.Subject) + ".");
+                        "DataTableCollection{reason}, but found {0}.",
+                        assertion.Subject);
             }
 
             return new AndConstraint<GenericCollectionAssertions<DataTable>>(assertion);

diff --git a/Tests/FluentAssertions.Specs/Common/TypeDescriptionUtilitySpecs.cs b/Tests/FluentAssertions.Specs/Common/TypeDescriptionUtilitySpecs.cs