Re-phrase failure message to include occurrence mode

fluentassertions · Apr 19, 2022 · 679f0ff · 679f0ff
1 parent e86f05a
commit 679f0ff
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/Src/FluentAssertions/Xml/XDocumentAssertions.cs b/Src/FluentAssertions/Xml/XDocumentAssertions.cs
@@ -314,8 +314,10 @@ public AndConstraint<XDocumentAssertions> NotBeEquivalentTo(XDocument unexpected
                         .ForConstraint(occurrenceConstraint, actualCount)
                         .BecauseOf(because, becauseArgs)
                         .FailWith(
-                            "Expected {context:subject} to have {0} child element(s) {1}{reason}, but found {2}.",
-                            occurrenceConstraint.ExpectedCount, expected.ToString(), actualCount);
+                            $"Expected {{context:subject}} to have {occurrenceConstraint.Mode} {{0}} child element(s) {{1}}{{reason}}, but found {{2}}.",
+                            occurrenceConstraint.ExpectedCount,
+                            expected.ToString(),
+                            actualCount);
                 }
             }
 

diff --git a/Src/FluentAssertions/Xml/XElementAssertions.cs b/Src/FluentAssertions/Xml/XElementAssertions.cs
@@ -332,8 +332,10 @@ public AndConstraint<XElementAssertions> HaveValue(string expected, string becau
                     .ForConstraint(occurrenceConstraint, actualCount)
                     .BecauseOf(because, becauseArgs)
                     .FailWith(
-                        "Expected {context:subject} to have {0} child element(s) {1}{reason}, but found {2}.",
-                        occurrenceConstraint.ExpectedCount, expected.ToString(), actualCount);
+                        $"Expected {{context:subject}} to have {occurrenceConstraint.Mode} {{0}} child element(s) {{1}}{{reason}}, but found {{2}}.",
+                        occurrenceConstraint.ExpectedCount,
+                        expected.ToString(),
+                        actualCount);
             }
 
             return new AndWhichConstraint<XElementAssertions, IEnumerable<XElement>>(this, xElements);

diff --git a/Tests/FluentAssertions.Specs/Xml/XDocumentAssertionSpecs.cs b/Tests/FluentAssertions.Specs/Xml/XDocumentAssertionSpecs.cs
@@ -1232,7 +1232,7 @@ public void When_asserting_document_has_two_child_elements_but_it_does_have_thre
 
             // Assert
             act.Should().Throw<XunitException>().WithMessage(
-                "Expected document to have 2 child element(s) \"child\", but found 3.");
+                "Expected document to have *exactly* 2 child element(s) \"child\", but found 3.");
         }
 
         [Fact]
@@ -1247,7 +1247,7 @@ public void Document_is_valid_and_expected_null_with_string_overload_it_fails()
                   </parent>");
 
             // Act
-            Action act = () => document.Should().HaveElement(null, Exactly.Twice());
+            Action act = () => document.Should().HaveElement((string)null, Exactly.Twice());
 
             // Assert
             act.Should().Throw<ArgumentNullException>().WithMessage(

diff --git a/Tests/FluentAssertions.Specs/Xml/XElementAssertionSpecs.cs b/Tests/FluentAssertions.Specs/Xml/XElementAssertionSpecs.cs
@@ -1282,7 +1282,7 @@ public void Element_has_two_child_elements_and_three_expected_it_fails()
 
             // Assert
             act.Should().Throw<XunitException>().WithMessage(
-                "Expected element to have 2 child element(s) \"child\", but found 3.");
+                "Expected element to have *exactly*2 child element(s) \"child\", but found 3.");
         }
 
         [Fact]
@@ -1330,7 +1330,8 @@ public void Chaining_which_after_asserting_and_the_element_has_more_than_two_chi
             var element = XElement.Parse(
                 @"<parent>
                     <child />
-                    
+                    <child />
+                    <child />
                   </parent>");
 
             // Act