Skip to content
Qodana

Redesign AssertionScope and how it travels over chained calls #1350

Sign in to view logs

Redesign AssertionScope and how it travels over chained calls

Redesign AssertionScope and how it travels over chained calls #1350

Triggered via pull request April 18, 2024 18:00
@dennisdoomendennisdoomen
synchronize #2539
Status Failure
Total duration 16m 5s
Artifacts 1

code_quality.yml

on: pull_request_target
Qodana Scan
15m 50s
Qodana Scan
Fit to window
Zoom out
Zoom in

Annotations

1 error, 47 warnings, and 1 notice
Qodana Scan
The number of problems exceeds the failThreshold
Add/remove 'this.' qualifier: Src/FluentAssertions/Execution/Assertion.cs#L21
Qualifier 'this.' is redundant
Disposal of a variable already captured by the 'using' statement: Tests/FluentAssertions.Specs/Execution/AssertionScope.ChainingApiSpecs.cs#L200
Variable 'scope' is captured by the 'using' statement and will be automatically disposed when the execution gets out of the scope
Disposal of a variable already captured by the 'using' statement: Tests/FluentAssertions.Specs/Execution/AssertionScope.ChainingApiSpecs.cs#L546
Variable 'scope' is captured by the 'using' statement and will be automatically disposed when the execution gets out of the scope
Member hides static member from outer class: Tests/FluentAssertions.Specs/Primitives/ObjectAssertionSpecs.cs#L42
Method 'bool Equals(object, object)' hides method from outer class
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L266
Field 'value' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L304
Field 'Field' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L294
Field 'Field' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L192
Field 'PublicField' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L194
Field 'InternalField' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L557
Field 'AdvancedBrowsableField' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L546
Field 'BrowsableField' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L583
Field 'FieldThatMightBeNonBrowsable' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L196
Field 'ProtectedInternalField' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L573
Field 'FieldThatMightBeNonBrowsable' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L299
Field 'Field' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L551
Field 'ExplicitlyBrowsableField' is assigned but its value is never used
Non-accessed field (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L264
Field 'Name' is assigned but its value is never used
Return value of a method annotated with [MustDisposeResource] is never disposed: Src/FluentAssertions/Formatting/MultidimensionalArrayFormatter.cs#L36
Local variable 'enumerator' is never disposed
Parameter hides member: Src/FluentAssertions/Execution/Assertion.cs#L42
Parameter 'reason' hides field 'Func FluentAssertions.Execution.Assertion.reason'
Parameter hides member: Src/FluentAssertions/Execution/NewGivenSelector.cs#L52
Parameter 'selector' hides field 'T FluentAssertions.Execution.NewGivenSelector.selector'
Possible 'System.NullReferenceException': Tests/FluentAssertions.Specs/Primitives/ObjectAssertionSpecs.cs#L42
Possible 'System.NullReferenceException'
Possible 'System.NullReferenceException': Tests/FluentAssertions.Specs/Primitives/ObjectAssertionSpecs.cs#L72
Possible 'System.NullReferenceException'
Possible 'System.NullReferenceException': Tests/FluentAssertions.Specs/Primitives/ObjectAssertionSpecs.cs#L72
Possible 'System.NullReferenceException'
Possible 'System.NullReferenceException': Tests/FluentAssertions.Equivalency.Specs/CollectionSpecs.cs#L2718
Possible 'System.NullReferenceException'
Redundant type declaration body: Tests/FluentAssertions.Specs/Types/TypeSelectorSpecs.cs#L800
Redundant empty enum declaration body
Redundant type declaration body: Tests/FluentAssertions.Specs/Types/TypeSelectorSpecs.cs#L886
Redundant empty enum declaration body
Redundant type declaration body: Tests/FluentAssertions.Specs/Types/TypeAssertionSpecs.cs#L133
Redundant empty enum declaration body
Redundant using directive: Src/FluentAssertions/AssertionExtensions.cs#L4
Using directive is not required by the code and can be safely removed
Get-only auto-property is never assigned: Src/FluentAssertions/Execution/ContinuedAssertionScope.cs#L145
Get-only auto-property 'ContextData' is never assigned
Get-only auto-property is never assigned: Src/FluentAssertions/Execution/ContinuedAssertionScope.cs#L147
Get-only auto-property 'FormattingOptions' is never assigned
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L140
Auto-property accessor 'ProtectedInternalProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L138
Auto-property accessor 'InternalProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Covariance.cs#L78
Auto-property accessor 'DerivedProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L586
Auto-property accessor 'PropertyThatMightBeNonBrowsable.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Covariance.cs#L73
Auto-property accessor 'BaseProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L575
Auto-property accessor 'PropertyThatMightBeNonBrowsable.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L554
Auto-property accessor 'ExplicitlyBrowsableProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L161
Auto-property accessor 'Property.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L242
Auto-property accessor 'Value.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs#L1015
Auto-property accessor 'Value.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L146
Auto-property accessor 'Property.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L548
Auto-property accessor 'BrowsableProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Browsability.cs#L560
Auto-property accessor 'AdvancedBrowsableProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L240
Auto-property accessor 'Name.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Accessibility.cs#L136
Auto-property accessor 'PublicProperty.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L166
Auto-property accessor 'Property.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.Covariance.cs#L90
Auto-property accessor 'OtherProp.get' is never used
Auto-property accessor is never used (private accessibility): Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.MemberHiding.cs#L156
Auto-property accessor 'Property.get' is never used

Artifacts

Produced during runtime
Name Size
qodana-report
1.88 MB