Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Len to FluentSlice, FluentMap, FluentString #124

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add Len to FluentSlice, FluentMap, FluentString #124

merged 2 commits into from
Feb 6, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 6, 2024

Why

Fixes #123

What

  • Add Len to FluentSlice, FluentMap, FluentString.
  • Opportunistic change: Refine doc comments for Any, All, None assertions.

Checklist

  • CHANGELOG.md is updated.
  • README.md is updated.
  • The code changes follow Effective Go.
  • The code changes follow CodeReviewComments.
  • The code changes are covered by tests.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d816578) 100.00% compared to head (e070248) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          511       529   +18     
=========================================
+ Hits           511       529   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared merged commit 18c484f into main Feb 6, 2024
6 checks passed
@pellared pellared deleted the len branch February 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Add length assertions for FluentSlice, FluentMap, FluentString
1 participant