log/console_adapter: support 'console' gem v1.25 #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to consider Ruby versions before 3.1. |
`Console::Terminal::Logger` class path has changed in `console` gem v1.25: socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12 Note: We can't stop considering the older versions because v1.25 requires Ruby v3.1 or older. For the v1.25, there is another issue about a warning(fluent#4488): Fiber#storage has borked keys and is being monkey-patched. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
force-pushed
the
console-adapter-support-console-v1.25
branch
from
9e9c5f2
to
daa6c76
Compare
|
About the failures on Windows, I have made an issue: It doesn't seem to have anything to do with this fix. |
Resolved. |
ashie
approved these changes
May 17, 2024
|
Thanks! |
|
We need to backport this to v1.16 |
Sorry, we should not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Console::Terminal::Loggerclass path has changed inconsolegem v1.25:socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12
This causes
LoadErrorforConsoleAdapter.It means that
LoadErroroccurs forplugin_helper/http_server/server, and Fluentd replaces the helper byplugin_helper/http_server/compat/server.It also causes the CI failures.
This PR fixes these problems.
Please see #4487 for details.
Note: We can't stop considering the older versions because v1.25
requires Ruby v3.1 or older.
Note: There is another issue about
consolegem v1.25:Docs Changes:
Not needed because this is a bug fix.
Release Note:
HttpServer helper: Fixed a problem that some Fluentd logs were not being output.