Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not show test detail immediately #4452

Merged
merged 1 commit into from Mar 27, 2024
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Mar 27, 2024

Which issue(s) this PR fixes:

N/A

What this PR does / why we need it:

TESTOPTS=-v shows running test and the result.
If something weird happen, it show error immediately.

As rake task executes many tests, so it may be better to delay showing test details later.

NOTE: --progress-style=fault-only helps you to focus on failure, but it is inconvenient when test case has stalled.

Docs Changes:

N/A

Release Note:

N/A

TESTOPTS=-v shows running test and the result.
If something weird happen, it show error immediately.

As rake task executes many tests, so it may be better to
delay showing test details later.

NOTE: --progress-style=fault-only helps you to focus on
failure, but it is inconvenient when test case has stalled.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! I want this!!

@kenhys
Copy link
Contributor Author

kenhys commented Mar 27, 2024

Error detail is shown before Omission:

image

@kenhys kenhys merged commit 5ffe67e into fluent:master Mar 27, 2024
15 of 16 checks passed
@kenhys kenhys deleted the no-show-detail branch March 27, 2024 08:42
@daipom
Copy link
Contributor

daipom commented Mar 27, 2024

Perfect!! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants