buffer: fix emit error of race condition #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a lot of diffs, but most of them are just indentation changes. I have changed |
|
There are three changes in this PR:
|
|
I am considering if I can add some tests... |
|
Even though it will be squashed, split indentation commit may be better. |
I see!! |
After 95438b2 (fluent#4342), there is a section where chunks do not have a lock in `write_step_by_step()`. `write_step_by_step()` must ensure their locks until passing them to the block. Otherwise, race condition can occur and it can cause emit error by IOError. Example of warning messages of emit error: [warn]: #0 emit transaction failed: error_class=IOError error="closed stream" location=... [warn]: #0 send an error event stream to @error: error_class=IOError error="closed stream" location=... Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
I separated commits for clarity. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
force-pushed
the
buffer-fix-emit-error-of-race-condition
branch
from
61a2b5a
to
fedb6d4
Compare
Thanks! I have separated them. |
|
I will check the behavior a little more tomorrow and add some tests if possible, but basically, I think this is prepared. |
daipom
changed the title
|
I have added a test. |
|
Thanks! |
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
After 95438b2 (#4342) (v1.16.4), there is a section where chunks do not have a lock in
write_step_by_step().write_step_by_step()must ensure their locks until passing them to the block.Otherwise, race condition can occur and it can cause emit error by IOError.
Example of warning messages of emit error:
Docs Changes:
Not needed.
Release Note:
Buffer: Fix emit error of v1.16.4 sometimes failing to process large data exceeding chunk size limit