Backport (v1.16): Refine CI (#4380) #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daipom
commented
Mar 11, 2024
daipom
commented
- #Refine CI #4380
Refine CI settings:
* Unify CI settings for each platforms to one file
* Don't run CI for Ruby head on each push/pull_request event
* Because Ruby head is continually changed and not released
yet, running CI one shot isn't so meaningful.
* Instead run it regularly on every Sunday.
* Add TESTOPT=-v to all platfroms
* It's useful to investigate when a test is stalled.
* Remove a hack for Ruby 3.0 on Windows
* It seems no longer needed.
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
daipom
force-pushed
the
v1.16-backport-4380
branch
from
1bc26c9
to
7b7116c
Compare
|
Should we use .yaml instead of .yml for consistency in fluent/fluentd? |
ashie
reviewed
Mar 11, 2024
Thanks for We can backport this later as well. |
because Ruby head is never supported on v1.16, and it seems wrong to use schedule trigger outside of the default branch (master). Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Takuro Ashie <ashie@clear-code.com>
ashie
approved these changes
Mar 11, 2024
|
Thanks! |
|
Need to backport some commits to fix Ruby 3.3 tests. I'm doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.