Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify WindowsFile #3774

Merged
merged 3 commits into from Jun 9, 2022
Merged

Simplify WindowsFile #3774

merged 3 commits into from Jun 9, 2022

Commits on Jun 7, 2022

  1. Simplify WindowsFile 

    We don't need to call CreateFile() by ourself, use standard File.open
and _get_osfhandle() instead. It will also fix a bug that WindowsFile
cannot open non-ascii path.

Fix #3769

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jun 7, 2022
    Copy the full SHA
    c315bc7 View commit details
    Browse the repository at this point in the history

  2. test_file_wrapper: Remove obsolete tests 

    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jun 7, 2022
    Copy the full SHA
    e1e9c47 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. file_wrapper: Fix a typo in a comment 

    In addition, add more descritpion about FileId.

[skip ci]

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    @ashie
    ashie committed Jun 9, 2022
    Copy the full SHA
    c95e3d1 View commit details
    Browse the repository at this point in the history