Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: Add Fluentd v1.17.0 release announcement (WIP) #312

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

blog: Add Fluentd v1.17.0 release announcement (WIP) #312

wants to merge 5 commits into from

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Apr 30, 2024

@daipom
blog: Add Fluentd v1.17.0 release announcement (WIP)
6f54acd 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
cosmo0920
cosmo0920 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added quite small nitpicks. Could you read carefully and get used to be usage of , (comma) and enumeration of two or more items with and?

content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
@daipom @cosmo0920
Apply suggestions from code review
60522ff 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>

Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
@daipom
Copy link
Contributor Author

daipom commented May 14, 2024

I added quite small nitpicks. Could you read carefully and get used to be usage of , (comma) and enumeration of two or more items with and?

Thanks! I understand! I will take care of that!

@daipom
Add description for enhancements
1834390 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
cosmo0920
cosmo0920 reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I found errors where are newly added sections.

content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
daipom and others added 2 commits May 16, 2024 10:05
@daipom @cosmo0920
Improve expression
b2aab89 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>

Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
@daipom @cosmo0920
Improve expression
fb90133 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>

Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daipom @cosmo0920