Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to Manning book #180

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

mp3monster
Copy link

Hope this is ok. Added a blog post about the New Manning book on Fluentd. Added link on guides page to blog post

Details of a new book on Fluentd
corrected link in blog post
Added link to blog post about Fluentd book
@ashie
Copy link
Member

ashie commented Mar 18, 2022

@mp3monster Sorry for my late response.

The contents seems O.K. for me.
Could you follow DCO?: https://github.com/fluent/fluentd-website/pull/180/checks?check_run_id=5511181615
(Add Signed-off-by: to your commit messages.)

Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing.
Could you add author's information like this?

fluentd-website/app.rb

Lines 58 to 88 in 88cfb18

AUTHORS = {
'masa' => {
'name' => "Masahiro Nakagawa",
'avatar_url' => 'https://avatars1.githubusercontent.com/u/16928?s=70',
'desc' => 'Masahiro (<a href="https://twitter.com/repeatedly">@repeatedly</a>) is the main maintainer of Fluentd. He works on Fluentd development and support full-time. He is also a committer of the D programming language.'
},
'kiyoto' => {
'name' => 'Kiyoto Tamura',
'avatar_url' => 'https://avatars3.githubusercontent.com/u/178554?s=70',
'desc' => 'Kiyoto (<a href="https://twitter.com/kiyototamura">@kiyototamura</a>) is a maintainer of Fluentd. He works on developer marketing and everything related to Fluentd at <a href="http://www.treasuredata.com/">Treasure Data</a>, the cloud-based, managed service for big data.'
},
'eduardo' => {
'name' => 'Eduardo Silva',
'avatar_url' => 'https://avatars3.githubusercontent.com/u/369718?v=3&s=70',
'desc' => 'Eduardo (<a href="https://twitter.com/edsiper">@edsiper</a>) is an Open Source Engineer at <a href="http://www.treasuredata.com/">Treasure Data</a>, he is part of Fluentd core team and maintains [Fluent Bit](http://fluentbit.io).'
},
'moris' => {
'name' => 'Satoshi Tagomori',
'avatar_url' => 'https://avatars3.githubusercontent.com/u/230654?v=3&s=70',
'desc' => 'Satoshi (a.k.a. Moris) (<a href="https://twitter.com/tagomoris">@tagomoris</a>) is a maintainer of Fluentd. He works on Fluentd, many Fluentd plugins, other OSS projects like msgpack-ruby, Norikra and so on, and distributed systems at <a href="http://www.treasuredata.com/">Treasure Data</a>.'
},
'clearcode' => {
'name' => 'ClearCode, Inc.',
'avatar_url' => 'https://avatars.githubusercontent.com/u/176515?v=3&s=70',
'desc' => '<a href="https://www.clear-code.com/">ClearCode, Inc.</a> is a software company specializing in the development of Free Software. We maintain Fluentd and its plugin ecosystem, and provide commercial support for them.'
},
'hisa' => {
'name' => 'Hisa Tanaka',
'avatar_url' => 'https://avatars.githubusercontent.com/u/19581009?v-3&s=70',
'desc' => 'Hisa (<a href="https://twitter.com/hisatomot">@hisatomot</a>) is a maintainer of Fluentd. He works on developer marketing and everything related to Fluentd at <a href="http://www.ctc-america.com/">ITOCHU Techno-Solutions America, Inc.</a>, the global IT solution provider, specialized in hyperscale, cloud native and app dev technologies, providing commercial services around Fluentd and Fluent Bit.'
},

@mp3monster
Copy link
Author

Sorry, could you point me to where the sign off is obtained from ?

@kenhys
Copy link
Contributor

kenhys commented Mar 22, 2022

DCO is explained at https://github.com/fluent/fluentd-website/pull/180/checks?check_run_id=5511181615
Actual steps are explained like this:

image

@mp3monster
Copy link
Author

can you confirm that Ive actioned the request properly please

@kenhys
Copy link
Contributor

kenhys commented Apr 1, 2022

@mp3monster

It is easy to be checked by: DCO is not satisfied.

image

if you are working on repository which contains the following branch,

% git remote -v
origin  git@github.com:mp3monster/fluentd-website.git (fetch)
origin  git@github.com:mp3monster/fluentd-website.git (push)
upstream        https://github.com/fluent/fluentd-website.git (fetch)
upstream        https://github.com/fluent/fluentd-website.git (push)

Maybe the following commands works.

git pull --rebase upstream master
git rebase HEAD~3 --signoff

NOTE: It is recommended to create a topic branch

@mp3monster mp3monster requested a review from ashie October 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants