Expose more options to OpenSearch image #1493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemcodM
force-pushed
the
more_opensearch_options
branch
from
9d4495b
to
cf70979
Compare
ashie
requested changes
Apr 30, 2024
Signed-off-by: Remco de Man <gitlab@remcodeman.nl>
RemcodM
force-pushed
the
more_opensearch_options
branch
from
cf70979
to
39f9f2f
Compare
Done! |
Signed-off-by: Remco de Man <gitlab@remcodeman.nl>
RemcodM
force-pushed
the
more_opensearch_options
branch
from
7547476
to
6f62c48
Compare
ashie
reviewed
Apr 30, 2024
Signed-off-by: Remco de Man <gitlab@remcodeman.nl>
Signed-off-by: Remco de Man <gitlab@remcodeman.nl>
Signed-off-by: Remco de Man <gitlab@remcodeman.nl>
ashie
reviewed
Apr 30, 2024
| sniffer_class_name "#{ENV['FLUENT_SNIFFER_CLASS_NAME'] || use_nil}" | ||
| request_timeout "#{ENV['FLUENT_OPENSEARCH_REQUEST_TIMEOUT'] || '5s'}" | ||
| application_name "#{ENV['FLUENT_OPENSEARCH_APPLICATION_NAME'] || use_default}" | ||
| bulk_message_request_threshold "#{ENV['FLUENT_OPENSEARCH_BULK_MESSAGE_REQUEST_THRESHOLD'] || use_nil}" |
There was a problem hiding this comment.
The default value of bulk_message_request_threshold is -1:
https://github.com/fluent/fluent-plugin-opensearch/blob/6a4b1868808555bb022112becc2746c2e080261f/lib/fluent/plugin/out_opensearch.rb#L95
https://github.com/fluent/fluent-plugin-opensearch/blob/6a4b1868808555bb022112becc2746c2e080261f/lib/fluent/plugin/out_opensearch.rb#L174
It would be better to use use_default if unsure the default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will give this a second try after #1466 got closed because of inactivity. I have rebased and updated this PR accordingly.
This PR exposes some more options of the
fluent-plugin-opensearchplug-in as environment variables to the Dockerfile, to be more in line with what the Elasticsearch images offer. This should make the transition from Elasticsearch to OpenSearch easier.It only changes the
fluentd.conffile for OpenSearch images. Thefluentd.confis generated using theMakefile, so it based on the template change included in this PR.Please let me know if any changes are necessary to get this merged.