out_datadog: Update the descriptions of special field options #8751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options are useful when there is no attribute in the incoming log that indicates the field to use for the `source` or `service` attributes, but otherwise the backend will automatically look for both in the incoming log attributes. Ref: fluent#8687 Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
|
This is a docs only update so I don't think most of the normal PR checklist is relevant, but let me know if you want me to run any of it. I'll open a separate PR to update the website docs. |
jszwedko
changed the title
datadog output field optionsout_datadog: Update the descriptions of special field options
jszwedko
added a commit
to jszwedko/fluent-bit-docs
that referenced
this pull request
Apr 23, 2024
Follow-up on the similar changes to the help docs in fluent-bit: fluent/fluent-bit#8751 Ref: fluent/fluent-bit#8751 Ref: fluent/fluent-bit#8687 Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
|
Hi @jszwedko, thanks for the PR. |
lecaros
pushed a commit
to fluent/fluent-bit-docs
that referenced
this pull request
Apr 25, 2024
Follow-up on the similar changes to the help docs in fluent-bit: fluent/fluent-bit#8751 Ref: fluent/fluent-bit#8751 Ref: fluent/fluent-bit#8687 Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
jszwedko
changed the title
out_datadog: Update the descriptions of special field options
Thanks for the pointer! I think the PR title should be ok now. |
lecaros
approved these changes
Apr 29, 2024
|
thanks for the contribution. Note that the requested change by @lecaros was about the commit subject (since this is a minor change I just change it in the squash process, all good) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options are useful when there is no attribute in the incoming log that indicates the field to use for the
sourceorserviceattributes, but otherwise the backend will automatically look for both in the incoming log attributes.Ref: #8687
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.