Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: wasm: upgrade wasm-micro-runtime to WAMR-1.3.2 #8744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasDevoogdt
Copy link
Contributor

@ThomasDevoogdt ThomasDevoogdt commented Apr 20, 2024

Main reason for the bump:

  • Enhance setting write gs base with cmake variable (#3066) --> fixes cross compilation on buildroot

Other news:

@ThomasDevoogdt ThomasDevoogdt changed the title lib: Upgrade wasm-micro-runtime to v1.3.2 build: wasm: upgrade wasm-micro-runtime to WAMR-1.3.2 Apr 20, 2024
@patrick-stephens
Copy link
Contributor

HadoLint is failing because this PR is too large...
However it does not touch the container definition so can be safely ignored.

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No Wasm related test breakages. 👍

@ThomasDevoogdt
Copy link
Contributor Author

Thx for the review. I also added some small remark about buildroot in another pull request. fluent/fluent-bit-docs#1357

@cosmo0920
Copy link
Contributor

cosmo0920 commented Apr 25, 2024

Ah, Buildroot is one of the embedded Linux! I actually worked for Yocto Linux which is another Embedded Linux distribution some time ago. Thanks for the addition into Fluent Bit documentation.

@ThomasDevoogdt
Copy link
Contributor Author

@edsiper, @cosmo0920, @patrick-stephens, can this be merged? I don't have the rights to do so.

@ThomasDevoogdt
Copy link
Contributor Author

@cosmo0920, @patrick-stephens, @edsiper kind ping

Main reason for the bump:

Enhance setting write gs base with cmake variable (bytecodealliance/wasm-micro-runtime#3066)
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
@patrick-stephens
Copy link
Contributor

What's up with the test failures?

@ThomasDevoogdt
Copy link
Contributor Author

What's up with the test failures?

No idea, all I want to do is bump the package to get some patch in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants