Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_bigquery: Add debug log for response payload when HTTP 200 OK #8736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oz-rw
Copy link

@oz-rw oz-rw commented Apr 19, 2024

This commit adds debug logging of the response payload. Even with HTTP 200 OK status response, BigQuery may return an error message in the payload. This can lead to data not being inserted into BigQuery silently.

Now it is easier to detect such cases with debug logging:


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • Debug log output from testing the change
[2024/04/19 07:59:05] [debug] [output:bigquery:bigquery.1] HTTP Status=200
[2024/04/19 07:59:05] [debug] [output:bigquery:bigquery.1] response
{
  "kind": "bigquery#tableDataInsertAllResponse",
  "insertErrors": [
    {
      "index": 0,
      "errors": [
        {
          "reason": "invalid",
          "location": "verticaluncertainty",
          "debugInfo": "",
          "message": "Invalid NUMERIC value: 5233.56298828125"
        }
      ]
    }
  ]
}
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

This commit adds debug logging of the response payload. Even with HTTP 200 OK
status response, BigQuery may return an error message in the payload. This
can lead to data not being inserted into BigQuery silently.

Now it is easier to detect such cases with debug logging:
```
[2024/04/19 07:59:05] [debug] [output:bigquery:bigquery.1] HTTP Status=200
[2024/04/19 07:59:05] [debug] [output:bigquery:bigquery.1] response
{
  "kind": "bigquery#tableDataInsertAllResponse",
  "insertErrors": [
    {
      "index": 0,
      "errors": [
        {
          "reason": "invalid",
          "location": "verticaluncertainty",
          "debugInfo": "",
          "message": "Invalid NUMERIC value: 5233.56298828125"
        }
      ]
    }
  ]
}
```

Signed-off-by: oz-rw <127842933+oz-rw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant