utils: use MachineGUID correctly. #8724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctly copy the buffer from RegQuery in flb_utils_get_machine_id when querying the MachineGUID. Signed-off-by: Phillip Whelan <phil@calyptia.com>
pwhelan
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
…tability. Add tests for flb_utils_get_machine_id to make sure the ID is consistent and is not full of zeroes. Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
…_id. Signed-off-by: Phillip Whelan <phil@calyptia.com>
|
@pwhelan something is happening in the windows side:
|
Signed-off-by: Phillip Whelan <phil@calyptia.com>
edsiper
requested changes
Apr 18, 2024
| @@ -1415,14 +1415,20 @@ int flb_utils_get_machine_id(char **out_id, size_t *out_size) | |||
|
|
|||
| if (status == ERROR_SUCCESS) { | |||
| *out_id = flb_calloc(1, dwBufSize+1); | |||
| memcpy(*out_id, buf, dwBufSize); | |||
There was a problem hiding this comment.
please validate the previous memory allocation before doing memcpy()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly copy the buffer from RegQuery in flb_utils_get_machine_id when querying the MachineGUID.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.